Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typeahead): dont throw error if latinize is off and no value for … #4480

Merged
merged 1 commit into from
Jul 5, 2018

Conversation

valorkin
Copy link
Member

@valorkin valorkin commented Jul 5, 2018

…input

fixes #4465

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@ghost ghost assigned valorkin Jul 5, 2018
@ghost ghost added the needs review label Jul 5, 2018
@valorkin valorkin merged commit fa6f174 into development Jul 5, 2018
@ghost ghost removed the needs review label Jul 5, 2018
@valorkin valorkin deleted the fix-typeahead-4465 branch July 5, 2018 13:06
@codecov
Copy link

codecov bot commented Jul 5, 2018

Codecov Report

Merging #4480 into development will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4480      +/-   ##
===============================================
- Coverage        71.45%   71.44%   -0.01%     
===============================================
  Files              259      259              
  Lines             8377     8378       +1     
  Branches          1561     1562       +1     
===============================================
  Hits              5986     5986              
- Misses            1984     1985       +1     
  Partials           407      407
Impacted Files Coverage Δ
src/typeahead/typeahead.directive.ts 74.86% <50%> (-0.4%) ⬇️
src/chronos/i18n/sk.ts 80.85% <0%> (-2.13%) ⬇️
src/chronos/i18n/cs.ts 84.74% <0%> (-1.7%) ⬇️
src/chronos/i18n/uk.ts 80.48% <0%> (+2.43%) ⬆️
src/chronos/i18n/pl.ts 77.77% <0%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86dd8e8...ab0c31b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

str.replace is not a function at Function.TypeaheadUtils.latinize
1 participant