refactor: Capitalize pt-br's locale month names #4455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
@gigioSouza please revert change to package-lock |
Codecov Report
@@ Coverage Diff @@
## development #4455 +/- ##
===============================================
- Coverage 71.42% 71.39% -0.03%
===============================================
Files 259 259
Lines 8377 8377
Branches 1561 1561
===============================================
- Hits 5983 5981 -2
- Misses 1985 1989 +4
+ Partials 409 407 -2
Continue to review full report at Codecov.
|
Revert package-lock.json modifications and force new commit
|
@valorkin |
valorkin
approved these changes
Jun 26, 2018
|
@gigioSouza thanks for PR! |
|
@valorkin All i18n files declare month names lowercased, why only this was changed? |
|
Not all, there are similar PR in momentjs |
|
PS is there are any i18n best practice for month names? |
I don't know one, however Angular (more specifically CLDR) uses a lowercased version. |
leo6104
pushed a commit
to leo6104/ngx-bootstrap
that referenced
this pull request
Oct 10, 2019
…re#4455) Revert package-lock.json modifications and force new commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.