Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modal): close only one directive modal with one esc pressing #4223

Merged
merged 2 commits into from
Apr 13, 2018
Merged

fix(modal): close only one directive modal with one esc pressing #4223

merged 2 commits into from
Apr 13, 2018

Conversation

YevheniiaMazur
Copy link

@YevheniiaMazur YevheniiaMazur commented Apr 13, 2018 •
edited
Loading

PR Checklist

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@YevheniiaMazur YevheniiaMazur requested a review from valorkin April 13, 2018 14:49
@ghost ghost assigned YevheniiaMazur Apr 13, 2018
@ghost ghost added the in progress label Apr 13, 2018
@ghost ghost added the in progress label Apr 13, 2018
@valorkin valorkin merged commit 83af591 into development Apr 13, 2018
@valorkin valorkin deleted the modal-directive-fix branch April 13, 2018 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valorkin valorkin valorkin approved these changes

Assignees

@YevheniiaMazur YevheniiaMazur

Labels
comp(modal) needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YevheniiaMazur @valorkin