Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datepicker): add aria-attributes #4141

Merged
merged 2 commits into from
Apr 5, 2018
Merged

feat(datepicker): add aria-attributes #4141

merged 2 commits into from
Apr 5, 2018

Conversation

tarusin
Copy link
Contributor

@tarusin tarusin commented Mar 29, 2018

Closes #4132

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Mar 29, 2018

Codecov Report

Merging #4141 into development will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4141      +/-   ##
===============================================
- Coverage        72.23%   72.17%   -0.07%     
===============================================
  Files              253      253              
  Lines             8238     8238              
  Branches          1565     1565              
===============================================
- Hits              5951     5946       -5     
- Misses            1866     1868       +2     
- Partials           421      424       +3
Impacted Files Coverage Δ
...hemes/bs/bs-daterangepicker-container.component.ts 30.76% <ø> (ø) ⬆️
...ker/themes/bs/bs-datepicker-container.component.ts 38.7% <ø> (ø) ⬆️
src/chronos/i18n/it.ts 71.42% <0%> (-28.58%) ⬇️
src/chronos/i18n/pl.ts 72.22% <0%> (-5.56%) ⬇️
src/chronos/i18n/uk.ts 78.04% <0%> (-2.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8ee1f8...a419ccd. Read the comment docs.

IlyaSurmay
IlyaSurmay previously approved these changes Mar 30, 2018
@YevheniiaMazur
Copy link

Tested, looks good

@valorkin valorkin merged commit 20c6b87 into valor-software:development Apr 5, 2018
@ghost ghost removed the ready for merge label Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants