Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datepicker): Added Slovenian locale support for datepicker #4035

Merged
merged 5 commits into from
Apr 25, 2018

Conversation

mihan
Copy link
Contributor

@mihan mihan commented Mar 20, 2018

No description provided.

@codecov
Copy link

codecov bot commented Mar 20, 2018

Codecov Report

❗ No coverage uploaded for pull request base (development@91ffd36). Click here to learn what that means.
The diff coverage is 24.28%.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #4035   +/-   ##
==============================================
  Coverage               ?   71.83%           
==============================================
  Files                  ?      254           
  Lines                  ?     8308           
  Branches               ?     1614           
==============================================
  Hits                   ?     5968           
  Misses                 ?     1894           
  Partials               ?      446
Impacted Files Coverage Δ
src/locale.ts 100% <100%> (ø)
src/chronos/i18n/sl.ts 23.18% <23.18%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91ffd36...331c0a4. Read the comment docs.

@mihan mihan changed the title Development Added Slovenian locale support for datepicker Mar 20, 2018
@valorkin
Copy link
Member

  • please add this language in docs
    so @YevheniiaMazur could test it
  • and migrate tests too

@valorkin valorkin changed the title Added Slovenian locale support for datepicker feat(datepicker): Added Slovenian locale support for datepicker Mar 29, 2018
@valorkin
Copy link
Member

like here: #3991

valorkin
valorkin previously approved these changes Apr 25, 2018
@ghost ghost assigned valorkin Apr 25, 2018
@ghost ghost added the needs review label Apr 25, 2018
@valorkin
Copy link
Member

@mihan thanks for your help!
sorry for a delay, was busy with organizing https://ngtalks.io

@valorkin valorkin merged commit 6e2e60f into valor-software:development Apr 25, 2018
@ghost ghost removed the needs review label Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants