feat(datepicker): esc can close datepicker #3966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #3966 +/- ##
===============================================
- Coverage 74.86% 74.83% -0.03%
===============================================
Files 276 276
Lines 8399 8422 +23
Branches 1596 1601 +5
===============================================
+ Hits 6288 6303 +15
- Misses 1668 1673 +5
- Partials 443 446 +3
Continue to review full report at Codecov.
|
|
Addresses #3890 |
valorkin
requested changes
Mar 29, 2018
| @@ -298,6 +301,16 @@ export class ComponentLoader<T> { | |||
| }); | |||
| }); | |||
| } | |||
| if (this._listenOpts.outsideEsc) { | |||
| const target = this._componentRef.location.nativeElement; | |||
| setTimeout(() => { | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ludmilanesvitiy
changed the title
Domainv
changed the title
ghost
assigned
Domainv
changed the title
Domainv
force-pushed
the
tab-closes-esc-exit
branch
from
6a9bf95 to
c00b348
Compare
|
'tab can close datepicker' functionality was cut out as unnecessary for now |
Domainv
previously approved these changes
Dec 13, 2018
|
Smoke tested in Chrome, FF -Esc always close the Datepicker. Looks good. |
leo6104
pushed a commit
to leo6104/ngx-bootstrap
that referenced
this pull request
Oct 10, 2019
Fixes valor-software#3890 * tab can close datpicker, esc can exit datpicker * fix(datepicker): conflicts resolve & leave only esc datepicker close * feat(datepicker): add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3890
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.