feat(datepicker): Add directive for inline datepicker #3956

martintro · 2018-03-08T10:48:21Z

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

read and followed the CONTRIBUTING.md guide.
built and tested the changes locally.
added/updated tests.
added/updated API documentation.
added/updated demos.

Closes valor-software#3955

codecov · 2018-03-08T11:28:27Z

Codecov Report

Merging #3956 into development will increase coverage by 0.07%.
The diff coverage is 77.41%.

@@               Coverage Diff               @@
##           development    #3956      +/-   ##
===============================================
+ Coverage        74.68%   74.76%   +0.07%     
===============================================
  Files              278      281       +3     
  Lines             8486     8547      +61     
  Branches          1623     1631       +8     
===============================================
+ Hits              6338     6390      +52     
- Misses            1698     1708      +10     
+ Partials           450      449       -1

Impacted Files	Coverage Δ
src/datepicker/bs-datepicker-inline.config.ts	`100% <100%> (ø)`
src/component-loader/component-loader.class.ts	`79.16% <100%> (+2.08%)`	⬆️
src/datepicker/public_api.ts	`100% <100%> (ø)`	⬆️
src/datepicker/bs-datepicker.module.ts	`100% <100%> (ø)`	⬆️
src/datepicker/bs-datepicker-inline.component.ts	`70.45% <70.45%> (ø)`
...mes/bs/bs-datepicker-inline-container.component.ts	`88.88% <88.88%> (ø)`
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89f7265...c7e8c72. Read the comment docs.

alexborghesi

looks good

Closes valor-software#3958

martintro · 2018-03-16T16:20:28Z

Closes #3958

amorenew · 2018-03-21T08:38:57Z

@martintro I wonder if you could add small sample how could we use this inline datepicker?
is it will be <datepicker></datepicker> or how it will be?
Thanks

martintro · 2018-03-21T08:46:43Z

@amorenew Please have a look at the demo files in the PR for example.
It’s like <bs-datepicker-inline></bs-datepicker-inline>

shyamal890 · 2018-03-25T11:03:56Z

Can another reviewer please review and merge this pull request to the main repo.

…ic dates" This reverts commit 47a1a11.

valorkin · 2018-05-03T13:27:41Z

@martintro LGTM!

evgenyfedorenko · 2018-05-10T22:24:01Z

Does this add only inline support for datepicker or daterange picker too ?

ishworthapaliya · 2018-06-13T11:38:31Z

Any update on this one?

martintro · 2018-06-13T11:57:45Z

@ishworthapaliya I hope so soon. I'm waiting for approval :)

x1unix · 2018-07-03T14:03:27Z

@valorkin, please review this PR.

pmramos · 2018-07-11T16:59:05Z

Could really use this!

martintro · 2019-01-16T09:30:21Z

When will this be merged?

valorkin

please fix imports and ready for merge

valorkin · 2019-01-17T21:43:33Z

src/index.ts

-import { TooltipModule } from './tooltip/tooltip.module';
-import { TypeaheadModule } from './typeahead/typeahead.module';
+/* tslint:disable: no-unused-variable */
+import { AccordionModule } from './accordion';


this type of import usually kills system js builds

@Domainv this is why I didn't yet merged

valorkin

Thanks!

…#3956) * feat(datepicker): Add directive for inline datepicker Closes valor-software#3955 * feat(datepicker): add support to set custom classes on specific dates Closes valor-software#3958 * Revert "feat(datepicker): add support to set custom classes on specific dates" This reverts commit 47a1a11. * feat(datepicker): resolve conflicts * fix(datepicker): fix tslint * fix(datepicker): clean up * fix(datepicker): add base spec for inline datepicker * fix(common): fix imports for system js

feat(datepicker): Add directive for inline datepicker

afcf540

Closes valor-software#3955

valorkin added comp(datepicker) needs review labels Mar 13, 2018

alexborghesi previously approved these changes Mar 15, 2018

View reviewed changes

feat(datepicker): add support to set custom classes on specific dates

47a1a11

Closes valor-software#3958

valorkin self-assigned this Mar 29, 2018

Revert "feat(datepicker): add support to set custom classes on specif…

82aa911

…ic dates" This reverts commit 47a1a11.

valorkin added ready for tests and removed needs review labels May 3, 2018

Domainv added the prio: medium label Jun 18, 2018

valorkin removed the ready for tests label Sep 3, 2018

valorkin removed their assignment Dec 3, 2018

valorkin added this to the 3.1.3 milestone Dec 3, 2018

Merge branch 'development' into bsDatepickerInline

b1a9e85

Domainv dismissed alexborghesi’s stale review via b1a9e85 December 4, 2018 16:09

ghost assigned Domainv Dec 4, 2018

ghost added the needs review label Dec 4, 2018

Merge branch 'development' into bsDatepickerInline

4601b88

valorkin removed this from the 3.1.3 milestone Dec 7, 2018

ludmilanesvitiy added needs fix and removed in test labels Dec 13, 2018

fix(datepicker): clean up

0995188

Domainv force-pushed the bsDatepickerInline branch from ab7a2ff to 0995188 Compare December 13, 2018 09:48

ghost added needs review and removed needs fix labels Dec 13, 2018

Domainv added 2 commits December 13, 2018 15:52

fix(datepicker): add base spec for inline datepicker

6bff2ca

Merge branch 'development' into bsDatepickerInline

686e14c

Domainv previously approved these changes Dec 13, 2018

View reviewed changes

Domainv added ready for merge and removed needs review labels Dec 13, 2018

Domainv modified the milestones: 3.1.4, 3.1.5 Jan 4, 2019

This was referenced Jan 10, 2019

feat(datepicker): Style/mark individual dates in datepicker #3958

Closed

feat(datepicker): add customClass option to the new version of datepicker #2848

Closed

ludmilanesvitiy previously approved these changes Jan 11, 2019

View reviewed changes

Merge branch 'development' into bsDatepickerInline

0052986

Domainv dismissed stale reviews from ludmilanesvitiy and themself via 0052986 January 18, 2019 09:25

Domainv previously approved these changes Jan 18, 2019

View reviewed changes

valorkin requested changes Jan 18, 2019

View reviewed changes

fix(common): fix imports for system js

4e55184

Domainv dismissed their stale review via 4e55184 January 18, 2019 16:28

Merge branch 'development' into bsDatepickerInline

c7e8c72

valorkin approved these changes Jan 18, 2019

View reviewed changes

valorkin merged commit d9a89b4 into valor-software:development Jan 18, 2019

ghost removed the ready for merge label Jan 18, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(datepicker): Add directive for inline datepicker #3956

feat(datepicker): Add directive for inline datepicker #3956

martintro commented Mar 8, 2018 •

edited

Loading

codecov bot commented Mar 8, 2018 •

edited

Loading

alexborghesi left a comment

martintro commented Mar 16, 2018

amorenew commented Mar 21, 2018 •

edited

Loading

martintro commented Mar 21, 2018 •

edited

Loading

shyamal890 commented Mar 25, 2018

valorkin commented May 3, 2018

evgenyfedorenko commented May 10, 2018

ishworthapaliya commented Jun 13, 2018

martintro commented Jun 13, 2018

x1unix commented Jul 3, 2018

pmramos commented Jul 11, 2018

martintro commented Jan 16, 2019

valorkin left a comment

valorkin Jan 17, 2019

valorkin Jan 18, 2019

Domainv Jan 18, 2019

valorkin left a comment

feat(datepicker): Add directive for inline datepicker #3956

feat(datepicker): Add directive for inline datepicker #3956

Conversation

martintro commented Mar 8, 2018 • edited Loading

PR Checklist

codecov bot commented Mar 8, 2018 • edited Loading

Codecov Report

alexborghesi left a comment

Choose a reason for hiding this comment

martintro commented Mar 16, 2018

amorenew commented Mar 21, 2018 • edited Loading

martintro commented Mar 21, 2018 • edited Loading

shyamal890 commented Mar 25, 2018

valorkin commented May 3, 2018

evgenyfedorenko commented May 10, 2018

ishworthapaliya commented Jun 13, 2018

martintro commented Jun 13, 2018

x1unix commented Jul 3, 2018

pmramos commented Jul 11, 2018

martintro commented Jan 16, 2019

valorkin left a comment

Choose a reason for hiding this comment

valorkin Jan 17, 2019

Choose a reason for hiding this comment

valorkin Jan 18, 2019

Choose a reason for hiding this comment

Domainv Jan 18, 2019

Choose a reason for hiding this comment

valorkin left a comment

Choose a reason for hiding this comment

martintro commented Mar 8, 2018 •

edited

Loading

codecov bot commented Mar 8, 2018 •

edited

Loading

amorenew commented Mar 21, 2018 •

edited

Loading

martintro commented Mar 21, 2018 •

edited

Loading