Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(demo): add null check in preventEmptyHrefNav method #3948

Merged
merged 1 commit into from
Mar 7, 2018

Conversation

IlyaSurmay
Copy link
Contributor

@IlyaSurmay IlyaSurmay commented Mar 7, 2018

This PR fixes error that is thrown on click on several elements on demo page (due to not very strict check in method that is used to prevent redirect from links with href="#")
01fcf3ebaf

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.

@valorkin valorkin merged commit 1a9c17d into development Mar 7, 2018
@ghost ghost removed the in progress label Mar 7, 2018
@valorkin valorkin deleted the fix-demo-prevent-nav branch March 7, 2018 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants