Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(demo): fix indent between progressbar and Randomize buttons #3752

Merged
merged 1 commit into from Feb 22, 2018
Merged

fix(demo): fix indent between progressbar and Randomize buttons #3752

merged 1 commit into from Feb 22, 2018

Conversation

ghost
Copy link

@ghost ghost commented Feb 12, 2018

  • added wrapper for progressbar blocks to set indent between progressbar block and Randomize buttons. http://joxi.ru/L216zjet69qYOA
  • deleted 'br' tags for consistency(replaced by wrappers)

Related to #3735

@codecov
Copy link

codecov bot commented Feb 12, 2018

Codecov Report

Merging #3752 into development will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3752      +/-   ##
===============================================
- Coverage        72.05%   71.99%   -0.07%     
===============================================
  Files              252      252              
  Lines             8159     8159              
  Branches          1552     1552              
===============================================
- Hits              5879     5874       -5     
- Misses            1858     1860       +2     
- Partials           422      425       +3
Impacted Files Coverage Δ
src/chronos/i18n/it.ts 71.42% <0%> (-28.58%) ⬇️
src/chronos/i18n/pl.ts 72.22% <0%> (-5.56%) ⬇️
src/chronos/i18n/uk.ts 78.04% <0%> (-2.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d30cb8...143ae84. Read the comment docs.

IlyaSurmay
IlyaSurmay previously approved these changes Feb 13, 2018
@YevheniiaMazur
Copy link

From where you've deleted br tags? How can I test this change (how it affects demo)?

@ghost ghost changed the title fix(demo): added wrapper to progressbar fix(demo): add wrapper to progressbar Feb 16, 2018
@ghost ghost changed the title fix(demo): add wrapper to progressbar fix(demo): fix indent between progressbar and Randomize buttons Feb 16, 2018
@ghost
Copy link
Author

ghost commented Feb 16, 2018

change description in pr

@YevheniiaMazur
Copy link

Tested, looks good

Copy link
Member

@valorkin valorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please extract inline styles


<div class="mb-2">
<progressbar [max]="max" [value]="dynamic">
<span style="color:white; white-space:nowrap;">{{dynamic}} / {{max}}</span>

This comment was marked as off-topic.

@valorkin valorkin merged commit 78a5e06 into valor-software:development Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants