fix(datepicker): remove position fixed #3610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #3610 +/- ##
============================================
Coverage 72.05% 72.05%
============================================
Files 252 252
Lines 8159 8159
Branches 1552 1552
============================================
Hits 5879 5879
Misses 1858 1858
Partials 422 422
Continue to review full report at Codecov.
|
IlyaSurmay
suggested changes
Feb 1, 2018
| @@ -173,6 +173,10 @@ export class BsDatepickerDirective implements OnInit, OnDestroy, OnChanges { | |||
| this.hide(); | |||
| }) | |||
| ); | |||
|
|
|||
| this._outsideScrollListener = this._renderer.listen('document', 'scroll', () => { | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
IlyaSurmay
suggested changes
Feb 1, 2018
| @@ -63,6 +64,16 @@ export const demoComponentContent: ContentSection[] = [ | |||
| `, | |||
| outlet: DemoDatePickerCustomFormatComponent | |||
| }, | |||
| { | |||
| title: 'Manual datepicker', | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
tarusin
changed the title
tarusin
changed the title
IlyaSurmay
previously approved these changes
Feb 8, 2018
IlyaSurmay
previously approved these changes
Feb 8, 2018
IlyaSurmay
approved these changes
Feb 9, 2018
|
Tested, looks good |
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #3300
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.