Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tabs): decompose manual selection section #3547

Merged

Conversation

artolshansky
Copy link
Contributor

@artolshansky artolshansky commented Jan 25, 2018

Decompose Manual selection to Manual and Disable selection

close #3545

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated demos.

Copy link
Contributor

@EvilAlexei EvilAlexei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR checklist should be completed

@@ -45,6 +46,13 @@ export const demoComponentContent: ContentSection[] = [
html: require('!!raw-loader?lang=markup!./demos/manual/manual.html'),
outlet: DemoTabsManualComponent
},
{
title: 'Disable selection',
anchor: 'tabs-disable',

This comment was marked as off-topic.

This comment was marked as off-topic.

@EvilAlexei EvilAlexei requested a review from valorkin January 25, 2018 16:42
@codecov
Copy link

codecov bot commented Jan 25, 2018

Codecov Report

❗ No coverage uploaded for pull request base (development@e52b896). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #3547   +/-   ##
==============================================
  Coverage               ?   72.03%           
==============================================
  Files                  ?      252           
  Lines                  ?     8159           
  Branches               ?     1552           
==============================================
  Hits                   ?     5877           
  Misses                 ?     1859           
  Partials               ?      423

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e52b896...8ac736f. Read the comment docs.

Decompose Manual selection to Manual and Disable selection

close valor-software#3545
@artolshansky artolshansky force-pushed the fix-tabs-decompose-manual branch from c3c5167 to 33cc275 Compare January 26, 2018 09:44
@artolshansky artolshansky changed the title fix(tabs): decompose manual selection section demo(tabs): decompose manual selection section Jan 26, 2018
@artolshansky artolshansky changed the title demo(tabs): decompose manual selection section docs(tabs): decompose manual selection section Jan 26, 2018
IlyaSurmay
IlyaSurmay previously approved these changes Feb 15, 2018
@YevheniiaMazur
Copy link

Tested, looks good

valorkin
valorkin previously approved these changes Mar 1, 2018
@valorkin valorkin dismissed stale reviews from IlyaSurmay and themself via 8ac736f March 1, 2018 12:47
@ghost ghost assigned valorkin Mar 1, 2018
@valorkin valorkin merged commit 6c9afd9 into valor-software:development Mar 1, 2018
@ghost ghost removed the ready for merge label Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs(tabs): decompose Manual selection
5 participants