Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(demo): fix input field width for daterangepicker at locales section #3543

Merged
merged 1 commit into from Feb 5, 2018
Merged

fix(demo): fix input field width for daterangepicker at locales section #3543

merged 1 commit into from Feb 5, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jan 25, 2018 •
edited by ghost
Loading

fix(datepicker): fix width in daterangerpicker at locates example

fixed closes #3302

@EvilAlexei EvilAlexei self-requested a review January 25, 2018 14:48
EvilAlexei
EvilAlexei suggested changes Jan 25, 2018
View reviewed changes
Copy link
Contributor

@EvilAlexei EvilAlexei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. PR message. Not fix(datepicker) -> fix(demo): fix input field width for daterangepicker at locales section
  2. Beware of typos - locates should be locales
  3. Where link to original issue?

@ghost ghost changed the title fix(datepicker): fix width in daterangerpicker at locates example fix(datepicker): fix width in daterangerpicker at locates example [#3302] Jan 25, 2018
@ghost ghost changed the title fix(datepicker): fix width in daterangerpicker at locates example [#3302] fix(demo): fix input field width for daterangepicker at locales section Jan 25, 2018
@ghost ghost changed the title fix(demo): fix input field width for daterangepicker at locales section fix(demo): fix input field width for daterangepicker at locales section Jan 25, 2018
@codecov
Copy link

codecov bot commented Jan 25, 2018 •
edited
Loading

Codecov Report

Merging #3543 into development will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3543      +/-   ##
===============================================
+ Coverage        72.07%   72.09%   +0.02%     
===============================================
  Files              251      251              
  Lines             8142     8142              
  Branches          1544     1544              
===============================================
+ Hits              5868     5870       +2     
+ Misses            1851     1850       -1     
+ Partials           423      422       -1
Impacted Files Coverage Δ
src/chronos/i18n/pl.ts 77.77% <0%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c09f0f9...f34a363. Read the comment docs.

@EvilAlexei EvilAlexei requested a review from valorkin January 25, 2018 16:43
@valorkin
Copy link
Member

valorkin commented Feb 5, 2018

@EvilAlexei @YevheniiaMazur reviewed and tested?

@EvilAlexei
Copy link
Contributor

@valorkin reviewed and approved

@valorkin valorkin merged commit 72c7cb3 into valor-software:development Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valorkin valorkin Awaiting requested review from valorkin

Assignees
No one assigned
Labels
comp(demo) issue needs review
Projects
None yet
Milestone
No milestone
2 participants
@valorkin @EvilAlexei