-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chronos): add danish language locale #3514
feat(chronos): add danish language locale #3514
Conversation
added danish locale configuration
Codecov Report
@@ Coverage Diff @@
## development #3514 +/- ##
==============================================
Coverage ? 72.02%
==============================================
Files ? 251
Lines ? 8146
Branches ? 1546
==============================================
Hits ? 5867
Misses ? 1852
Partials ? 427
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome!
Small thing left: export daLocale in srx/index.ts
Or system.js users will not be able to import it :(
|
Indeed, I forgot that I ended up with this hack for system.js |
Tested, looks good |
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.