Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chronos): add danish language locale #3514

Merged

Conversation

perhp
Copy link
Contributor

@perhp perhp commented Jan 22, 2018

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.

added danish locale configuration
@codecov
Copy link

codecov bot commented Jan 22, 2018

Codecov Report

❗ No coverage uploaded for pull request base (development@927b510). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #3514   +/-   ##
==============================================
  Coverage               ?   72.02%           
==============================================
  Files                  ?      251           
  Lines                  ?     8146           
  Branches               ?     1546           
==============================================
  Hits                   ?     5867           
  Misses                 ?     1852           
  Partials               ?      427
Impacted Files Coverage Δ
src/locale.ts 100% <100%> (ø)
src/chronos/i18n/da.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 927b510...76440c2. Read the comment docs.

Copy link
Member

@valorkin valorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!
Small thing left: export daLocale in srx/index.ts
Or system.js users will not be able to import it :(

@perhp perhp changed the title feat(locale): add danish language locale feat(chronos): add danish language locale Jan 24, 2018
@perhp
Copy link
Contributor Author

perhp commented Jan 24, 2018

daLocale is exported from src/locale.ts which is exported from src/index.ts by export * from './locale';.
That should do it? :)

@valorkin
Copy link
Member

Indeed, I forgot that I ended up with this hack for system.js

@YevheniiaMazur
Copy link

Tested, looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants