Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datepicker): added date and range min, max and invalid validation #3499

Merged
merged 1 commit into from
Jan 19, 2018

Conversation

valorkin
Copy link
Member

closes #2727
closes #3498

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@ghost ghost assigned valorkin Jan 19, 2018
@ghost ghost added the in progress label Jan 19, 2018
@valorkin valorkin added this to the v2.0.0-rc.2 milestone Jan 19, 2018
@valorkin valorkin force-pushed the feat-datepicker-input-validation branch from 4ae81f5 to bd33dcd Compare January 19, 2018 17:04
@codecov
Copy link

codecov bot commented Jan 19, 2018

Codecov Report

Merging #3499 into development will decrease coverage by 0.19%.
The diff coverage is 36.58%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development    #3499     +/-   ##
==============================================
- Coverage        72.27%   72.07%   -0.2%     
==============================================
  Files              250      250             
  Lines             8104     8140     +36     
  Branches          1538     1548     +10     
==============================================
+ Hits              5857     5867     +10     
- Misses            1821     1847     +26     
  Partials           426      426
Impacted Files Coverage Δ
...c/datepicker/bs-daterangepicker-input.directive.ts 27.58% <33.33%> (+0.44%) ⬆️
src/datepicker/bs-datepicker-input.directive.ts 30.76% <39.13%> (-1.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d714e75...2426601. Read the comment docs.

@valorkin valorkin force-pushed the feat-datepicker-input-validation branch from bd33dcd to 2426601 Compare January 19, 2018 17:25
@valorkin valorkin merged commit 7b43295 into development Jan 19, 2018
@valorkin valorkin deleted the feat-datepicker-input-validation branch January 19, 2018 17:26
@ghost ghost removed the ready for tests label Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant