Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): Angular 5.2 ngc build produces node_modules folder with missing js files #3458

Closed
AllNamesRTaken opened this issue Jan 15, 2018 · 3 comments

Comments

@AllNamesRTaken
Copy link

When building the generated node_modules folder is missing .js files referenced in the factories.

This problem is also described here. Since the imports are re-written to relative paths but the original js files are omitted, bundling using e.g. rollup fails.

Reproduction

  • compile using ngc

ngx-bootstrap: 2.0.0-rc0

Angular: 5.2.0

Bootstrap: 3

Build system: ngc

@valorkin
Copy link
Member

how to reproduce?

you mean: you have cloned ngx-bs and cannot start it?

@IlyaSurmay
Copy link
Contributor

Please provide a repo with reproduction.

@YevheniiaMazur YevheniiaMazur changed the title [bug] Angular 5.2 ngc build produces node_modules folder with missing js files fix(build): Angular 5.2 ngc build produces node_modules folder with missing js files Jan 17, 2018
@AllNamesRTaken
Copy link
Author

As Requested:
my repo

It doesnt do anything, just compiles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants