Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): isBs3() function not work properly with chrome + unzoom + windows #3446

Closed
FightTheWar opened this issue Jan 12, 2018 · 6 comments

Comments

@FightTheWar
Copy link

Bug description or feature request:

isBs3() function not work properly with chrome in some situation
You can try the example whith Chrome browser, unzoom to 50% and reload the page
First the function return true, the after relaod it will be false

The problem come from utils/theme-provider.js
In _guessBsVersion() you test rect.top === 0
But with unzoom this test can be true with Bootstrap 3 + chrome

Plunker/StackBlitz that reproduces the issue:

https://plnkr.co/edit/ZFXpDBBcOegQyKjByMEi?p=preview

Versions of ngx-bootstrap, Angular, and Bootstrap:

ngx-bootstrap: 2.0.0-rc.0
Angular: 5.1.2
Bootstrap: 3.3.7
Chrome version 63.0.3239.132

@IlyaSurmay
Copy link
Contributor

Works fine on my machine
qtlydtwhsko4set3oi_ula
modified plunker with bigger font - https://plnkr.co/edit/5xc2i4DpnEAbAnvqYwnp?p=preview

@FightTheWar
Copy link
Author

FightTheWar commented Jan 12, 2018

Did you reload the page ? And try without font size modification

image

I'm using Windows 7 and we have the same problem on every laptop in the company

This is not a big issue because we can fix the right version at startup

@valorkin
Copy link
Member

@IlyaSurmay did you cleaned local storage before testing? :)

@valorkin
Copy link
Member

ok, I can not reproduce it too

@valorkin
Copy link
Member

@IlyaSurmay need to try on windows

@FightTheWar
Copy link
Author

Hello, I confirm, it occurs only under windows

@YevheniiaMazur YevheniiaMazur changed the title Incorrect bootstrap version detection with chrome + unzoom fix(build): isBs3() function not work properly with chrome + unzoom + windows Jan 17, 2018
@Domainv Domainv added the issue label Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants