-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build): isBs3() function not work properly with chrome + unzoom + windows #3446
Labels
Comments
Works fine on my machine |
@IlyaSurmay did you cleaned local storage before testing? :) |
ok, I can not reproduce it too |
@IlyaSurmay need to try on windows |
Hello, I confirm, it occurs only under windows |
YevheniiaMazur
changed the title
Incorrect bootstrap version detection with chrome + unzoom
fix(build): isBs3() function not work properly with chrome + unzoom + windows
Jan 17, 2018
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug description or feature request:
isBs3() function not work properly with chrome in some situation
You can try the example whith Chrome browser, unzoom to 50% and reload the page
First the function return true, the after relaod it will be false
The problem come from utils/theme-provider.js
In _guessBsVersion() you test rect.top === 0
But with unzoom this test can be true with Bootstrap 3 + chrome
Plunker/StackBlitz that reproduces the issue:
https://plnkr.co/edit/ZFXpDBBcOegQyKjByMEi?p=preview
Versions of ngx-bootstrap, Angular, and Bootstrap:
ngx-bootstrap: 2.0.0-rc.0
Angular: 5.1.2
Bootstrap: 3.3.7
Chrome version 63.0.3239.132
The text was updated successfully, but these errors were encountered: