Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typeahead): fix autoselect on tab key with typeaheadMinLength=0 #3378

Merged
merged 1 commit into from
Jan 5, 2018

Conversation

IlyaSurmay
Copy link
Contributor

fixes #3106

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.

@codecov
Copy link

codecov bot commented Jan 2, 2018

Codecov Report

Merging #3378 into development will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3378      +/-   ##
===============================================
- Coverage        65.03%   65.02%   -0.02%     
===============================================
  Files              210      210              
  Lines             5691     5692       +1     
  Branches          1000     1000              
===============================================
  Hits              3701     3701              
- Misses            1724     1725       +1     
  Partials           266      266
Impacted Files Coverage Δ
src/typeahead/typeahead.directive.ts 74.87% <0%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ad82bb...a0ba58c. Read the comment docs.

@valorkin valorkin added this to the v2.0.0-rc.2 milestone Jan 5, 2018
@valorkin valorkin merged commit eaed118 into development Jan 5, 2018
@valorkin valorkin deleted the fix-typeahead-autoselect branch January 5, 2018 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typeahead with typeaheadMinLength=0 is automatically selecting a value on Tab
2 participants