Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): fix circular dependency warning #3359

Merged
merged 1 commit into from
Jan 5, 2018
Merged

Conversation

IlyaSurmay
Copy link
Contributor

PR Checklist

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.

@IlyaSurmay IlyaSurmay requested a review from valorkin December 25, 2017 17:24
@ghost ghost assigned IlyaSurmay Dec 25, 2017
@ghost ghost added the in progress label Dec 25, 2017
@codecov
Copy link

codecov bot commented Dec 25, 2017

Codecov Report

Merging #3359 into development will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3359      +/-   ##
===============================================
+ Coverage        65.03%   65.03%   +<.01%     
===============================================
  Files              210      210              
  Lines             5691     5689       -2     
  Branches          1000      999       -1     
===============================================
- Hits              3701     3700       -1     
  Misses            1724     1724              
+ Partials           266      265       -1
Impacted Files Coverage Δ
src/modal/modal-container.component.ts 18.86% <ø> (-1.14%) ⬇️
src/modal/bs-modal.service.ts 22.85% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86a747c...fc91603. Read the comment docs.

@valorkin valorkin added this to the v2.0.0-rc.2 milestone Jan 5, 2018
@valorkin valorkin merged commit 59c0bf9 into development Jan 5, 2018
@valorkin valorkin deleted the fix-modal-warning branch January 5, 2018 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants