fix(typeahead): fix flickering #3321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## development #3321 +/- ##
===============================================
- Coverage 65.43% 64.98% -0.45%
===============================================
Files 210 210
Lines 5647 5695 +48
Branches 889 1002 +113
===============================================
+ Hits 3695 3701 +6
+ Misses 1755 1728 -27
- Partials 197 266 +69
Continue to review full report at Codecov.
|
valorkin
requested changes
Jan 5, 2018
src/typeahead/typeahead.directive.ts
Outdated
| @@ -291,7 +291,13 @@ export class TypeaheadDirective implements OnInit, OnDestroy { | |||
| dropup: this.dropup | |||
| }); | |||
|
|
|||
| this._outsideClickListener = this.renderer.listen('document', 'click', () => { | |||
| this._outsideClickListener = this.renderer.listen('document', 'click', (e: MouseEvent) => { | |||
| if (this.typeaheadMinLength === 0) { | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
IlyaSurmay
force-pushed
the
fix-typeahead-flickering
branch
from
fe3f3a1 to
b9a15cb
Compare
valorkin
approved these changes
Jan 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3315
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.