Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update timepicker.reducer.ts #3207

Merged
merged 1 commit into from
Dec 7, 2017
Merged

Update timepicker.reducer.ts #3207

merged 1 commit into from
Dec 7, 2017

Conversation

chonggit
Copy link
Contributor

@chonggit chonggit commented Dec 6, 2017

fix if state.value == null _newState.value will set to '1970-01-01 08:00:00'

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

fix if state.value == null _newState.value will set to '1970-01-01 08:00:00'
@codecov
Copy link

codecov bot commented Dec 6, 2017

Codecov Report

Merging #3207 into development will decrease coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3207      +/-   ##
===============================================
- Coverage         65.2%   65.19%   -0.02%     
===============================================
  Files              209      209              
  Lines             5653     5654       +1     
  Branches           996      997       +1     
===============================================
  Hits              3686     3686              
  Misses            1704     1704              
- Partials           263      264       +1
Impacted Files Coverage Δ
src/timepicker/reducer/timepicker.reducer.ts 89.18% <50%> (-2.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4131489...3f3dea0. Read the comment docs.

@YevheniiaMazur
Copy link

Tested, looks good

@valorkin valorkin merged commit 8761038 into valor-software:development Dec 7, 2017
@ghost ghost removed the ready for merge label Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants