Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datepicker): respect first day of week in current locale #2970

Merged
merged 1 commit into from
Nov 3, 2017

Conversation

valorkin
Copy link
Member

@valorkin valorkin commented Nov 3, 2017

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@YevheniiaMazur
Copy link

Tested, looks good

@codecov
Copy link

codecov bot commented Nov 3, 2017

Codecov Report

Merging #2970 into development will decrease coverage by 0.09%.
The diff coverage is 35.29%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development    #2970     +/-   ##
==============================================
- Coverage        65.78%   65.68%   -0.1%     
==============================================
  Files              207      207             
  Lines             5606     5619     +13     
  Branches           983      985      +2     
==============================================
+ Hits              3688     3691      +3     
- Misses            1656     1666     +10     
  Partials           262      262
Impacted Files Coverage Δ
src/datepicker/utils/bs-calendar-utils.ts 34.78% <25%> (-6.4%) ⬇️
src/datepicker/engine/format-days-calendar.ts 35.71% <42.85%> (-8.74%) ⬇️
src/datepicker/reducer/bs-datepicker.reducer.ts 13.63% <50%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e16efee...24e707b. Read the comment docs.

@valorkin valorkin merged commit 1b6ed56 into development Nov 3, 2017
@valorkin valorkin deleted the feat-datepicker-use-fdow branch November 3, 2017 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants