Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(timepicker): correctly set initial time manually #2945

Merged
merged 1 commit into from
Nov 2, 2017

Conversation

valorkin
Copy link
Member

@valorkin valorkin commented Nov 1, 2017

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Nov 1, 2017

Codecov Report

Merging #2945 into development will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #2945      +/-   ##
===============================================
+ Coverage         70.7%   70.73%   +0.03%     
===============================================
  Files              137      137              
  Lines             4165     4166       +1     
  Branches           737      738       +1     
===============================================
+ Hits              2945     2947       +2     
  Misses             914      914              
+ Partials           306      305       -1
Impacted Files Coverage Δ
src/timepicker/timepicker.component.ts 91.5% <100%> (+0.08%) ⬆️
src/timepicker/timepicker.utils.ts 93.75% <0%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37b8454...9ef3f04. Read the comment docs.

@YevheniiaMazur
Copy link

Tested, looks good

@valorkin valorkin merged commit 0071733 into development Nov 2, 2017
@valorkin valorkin deleted the fix-timepicker-initial-manual-time branch November 2, 2017 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants