Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rating): fixed rating in onpush components #2943

Merged
merged 3 commits into from
Nov 2, 2017

Conversation

valorkin
Copy link
Member

@valorkin valorkin commented Nov 1, 2017

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@valorkin valorkin added this to the v2.0.0 milestone Nov 1, 2017
@YevheniiaMazur
Copy link

YevheniiaMazur commented Nov 1, 2017

Tested, demo looks good. Needs fixing test:
screenshot from 2017-11-01 16-52-28

@codecov
Copy link

codecov bot commented Nov 2, 2017

Codecov Report

❗ No coverage uploaded for pull request base (development@b28838a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #2943   +/-   ##
==============================================
  Coverage               ?   70.69%           
==============================================
  Files                  ?      137           
  Lines                  ?     4174           
  Branches               ?      739           
==============================================
  Hits                   ?     2951           
  Misses                 ?      916           
  Partials               ?      307
Impacted Files Coverage Δ
src/rating/rating.component.ts 68.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b28838a...eba6ae1. Read the comment docs.

@valorkin valorkin merged commit bb0af30 into development Nov 2, 2017
@valorkin valorkin deleted the fix-rating-onpush branch November 2, 2017 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants