Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datepicker): Add-Init-Config for the first initialization #2897

Merged
merged 2 commits into from
Nov 22, 2017

Conversation

BGXi
Copy link
Contributor

@BGXi BGXi commented Oct 23, 2017

Add-Init-Config for DateRangePicker for the first initialization of the international date display.

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Oct 23, 2017

Codecov Report

Merging #2897 into development will decrease coverage by 5.22%.
The diff coverage is 16.66%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #2897      +/-   ##
===============================================
- Coverage        70.69%   65.46%   -5.23%     
===============================================
  Files              137      207      +70     
  Lines             4159     5603    +1444     
  Branches           735      985     +250     
===============================================
+ Hits              2940     3668     +728     
- Misses             914     1673     +759     
+ Partials           305      262      -43
Impacted Files Coverage Δ
src/datepicker/bs-daterangepicker.component.ts 34.66% <16.66%> (ø)
src/datepicker/bs-datepicker.component.ts 36% <16.66%> (ø)
src/bs-moment/locale/index.ts 100% <0%> (ø) ⬆️
...picker/themes/bs/bs-custom-dates-view.component.ts 100% <0%> (ø)
...cker/themes/bs/bs-years-calendar-view.component.ts 73.68% <0%> (ø)
src/bs-moment/i18n/cs.ts 3.7% <0%> (ø)
src/datepicker/engine/format-days-calendar.ts 35.71% <0%> (ø)
src/datepicker/engine/flag-days-calendar.ts 15.62% <0%> (ø)
...hemes/bs/bs-daterangepicker-container.component.ts 30.76% <0%> (ø)
src/datepicker/engine/view-mode.ts 50% <0%> (ø)
... and 90 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 479b046...a695929. Read the comment docs.

@valorkin
Copy link
Member

valorkin commented Nov 2, 2017

@BGXi hey, can you please do the same for datepicker?

@valorkin valorkin added this to the v2.0.0 milestone Nov 2, 2017
@valorkin valorkin changed the title Add-Init-Config for DateRangePicker for the first initialization feat(datepicker): Add-Init-Config for the first initialization Nov 2, 2017
@YevheniiaMazur
Copy link

Tested, looks good

@valorkin valorkin merged commit 7ec97f8 into valor-software:development Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants