Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tabs): fix customClass for tab content #2883

Merged
merged 1 commit into from
Oct 20, 2017
Merged

fix(tabs): fix customClass for tab content #2883

merged 1 commit into from
Oct 20, 2017

Conversation

IlyaSurmay
Copy link
Contributor

fix for customClass, which behavior was broken by #2813

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.

@IlyaSurmay IlyaSurmay requested a review from valorkin October 19, 2017 15:25
@valorkin valorkin added this to the v2.0.0 milestone Oct 20, 2017
@YevheniiaMazur
Copy link

Needs fix: after running npm run demo.serve got 404 error
404errorngx

@YevheniiaMazur
Copy link

Tested, looks good after cleaninstall (with removing gh-pages and node modules)

@valorkin valorkin merged commit 8e50e66 into development Oct 20, 2017
@valorkin valorkin deleted the fix-tab-class branch October 20, 2017 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valorkin valorkin Awaiting requested review from valorkin

Assignees
No one assigned
Labels
comp(tabs) ready for merge
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@IlyaSurmay @YevheniiaMazur @valorkin