WIP feat(docs): new aside menu #2851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #2851 +/- ##
===========================================
Coverage 70.7% 70.7%
===========================================
Files 137 137
Lines 4165 4165
Branches 737 737
===========================================
Hits 2945 2945
Misses 914 914
Partials 306 306Continue to review full report at Codecov.
|
added 7 commits
October 18, 2017 18:05
EvilAlexei
force-pushed
the
doc-aside-menu
branch
from
8092502 to
957d247
Compare
# Conflicts: # demo/src/app/components/+alerts/alerts-section.component.html # demo/src/app/components/+buttons/buttons-section.component.html # demo/src/app/components/+carousel/carousel-section.component.html # demo/src/app/components/+datepicker/demo-datepicker.module.ts # demo/src/app/components/+dropdown/dropdown-section.component.html # demo/src/app/components/+modal/demos/index.ts # demo/src/app/components/+modal/modal-section.component.html # demo/src/app/components/+typeahead/demos/index.ts # demo/src/app/components/+typeahead/typeahead-section.component.html
valorkin
reviewed
Oct 26, 2017
| goToSection(event): void { | ||
| const item: HTMLElement = event.target; | ||
|
|
||
| if (item.hasAttribute('ng-reflect-fragment')) { |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
valorkin
previously approved these changes
Oct 27, 2017
EvilAlexei
force-pushed
the
doc-aside-menu
branch
from
d3ae2e6 to
544ef14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.