Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typeahead): select active match on TAB #2839

Merged

Conversation

ahtshamraziq
Copy link
Contributor

Fixes #2295

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.

@codecov
Copy link

codecov bot commented Oct 13, 2017

Codecov Report

Merging #2839 into development will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #2839      +/-   ##
===============================================
- Coverage        70.44%   70.39%   -0.06%     
===============================================
  Files              137      137              
  Lines             4094     4097       +3     
  Branches           712      713       +1     
===============================================
  Hits              2884     2884              
- Misses             912      915       +3     
  Partials           298      298
Impacted Files Coverage Δ
src/typeahead/typeahead.directive.ts 70.74% <0%> (-1.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee7081d...e43fe22. Read the comment docs.

@YevheniiaMazur
Copy link

Tested, looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants