Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): fix tooltip with delay only appearing once #2826

Merged

Conversation

ahtshamraziq
Copy link
Contributor

Fixes #2606

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.

@ahtshamraziq ahtshamraziq force-pushed the fix-tooltip-popup-delay branch from 522a06e to c331d04 Compare October 12, 2017 09:43
@codecov
Copy link

codecov bot commented Oct 12, 2017

Codecov Report

Merging #2826 into development will decrease coverage by 0.03%.
The diff coverage is 33.33%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #2826      +/-   ##
===============================================
- Coverage        70.44%   70.41%   -0.04%     
===============================================
  Files              137      137              
  Lines             4094     4096       +2     
  Branches           712      713       +1     
===============================================
  Hits              2884     2884              
- Misses             912      913       +1     
- Partials           298      299       +1
Impacted Files Coverage Δ
src/tooltip/tooltip.directive.ts 56.7% <33.33%> (-1.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0ff1c1...3915771. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 12, 2017

Codecov Report

Merging #2826 into development will decrease coverage by 0.03%.
The diff coverage is 16.66%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #2826      +/-   ##
===============================================
- Coverage        70.44%   70.41%   -0.04%     
===============================================
  Files              137      137              
  Lines             4094     4096       +2     
  Branches           712      713       +1     
===============================================
  Hits              2884     2884              
- Misses             912      913       +1     
- Partials           298      299       +1
Impacted Files Coverage Δ
src/tooltip/tooltip.directive.ts 56.7% <16.66%> (-1.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bedcee...c331d04. Read the comment docs.

IlyaSurmay
IlyaSurmay previously approved these changes Oct 12, 2017
@valorkin
Copy link
Member

hey @ahtshamraziq
if you wouldn't mind I will try to fix sauce lab tests for PRs using your branch,
cuz issue can be reproduced only from forks, and from folks who doesn't have write access to ngx-bootstrap

@valorkin valorkin merged commit e625faa into valor-software:development Oct 18, 2017
@valorkin
Copy link
Member

@ahtshamraziq thanks again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants