Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typeahead): add scroll support #2821

Merged
merged 4 commits into from
Oct 20, 2017
Merged

Conversation

IlyaSurmay
Copy link
Contributor

Closes #1168

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

valorkin
valorkin previously approved these changes Oct 13, 2017
@codecov
Copy link

codecov bot commented Oct 13, 2017

Codecov Report

Merging #2821 into development will increase coverage by 0.3%.
The diff coverage is 71.01%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development    #2821     +/-   ##
==============================================
+ Coverage        70.44%   70.75%   +0.3%     
==============================================
  Files              137      137             
  Lines             4094     4151     +57     
  Branches           712      732     +20     
==============================================
+ Hits              2884     2937     +53     
+ Misses             912      910      -2     
- Partials           298      304      +6
Impacted Files Coverage Δ
src/typeahead/typeahead.directive.ts 71.8% <42.85%> (-0.09%) ⬇️
src/typeahead/typeahead-container.component.ts 79.83% <78.18%> (+6.98%) ⬆️
src/utils/utils.class.ts 80% <0%> (+30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee7081d...335c165. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants