Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(popover): don't show popover if content is undefined, #1504 #2815

Merged
merged 5 commits into from
Oct 20, 2017
Merged

feat(popover): don't show popover if content is undefined, #1504 #2815

merged 5 commits into from
Oct 20, 2017

Conversation

LimarenkoDenis
Copy link
Contributor

@LimarenkoDenis LimarenkoDenis commented Oct 6, 2017

#1504

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Oct 6, 2017

Codecov Report

Merging #2815 into development will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #2815   +/-   ##
============================================
  Coverage        70.44%   70.44%           
============================================
  Files              137      137           
  Lines             4094     4094           
  Branches           712      712           
============================================
  Hits              2884     2884           
  Misses             912      912           
  Partials           298      298
Impacted Files Coverage Δ
src/popover/popover.directive.ts 80% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5613042...3e44c8c. Read the comment docs.

@valorkin valorkin added this to the v2.0.0 milestone Oct 13, 2017
@YevheniiaMazur
Copy link

Tested, looks good

@valorkin valorkin modified the milestone: v2.0.0 Oct 20, 2017
@valorkin valorkin merged commit 64d13e7 into valor-software:development Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants