Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tab): add tab id support #2405

Merged
merged 2 commits into from
Oct 13, 2017
Merged

feat(tab): add tab id support #2405

merged 2 commits into from
Oct 13, 2017

Conversation

IlyaSurmay
Copy link
Contributor

closes #2353

@codecov
Copy link

codecov bot commented Aug 11, 2017

Codecov Report

Merging #2405 into development will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #2405   +/-   ##
============================================
  Coverage        70.48%   70.48%           
============================================
  Files              137      137           
  Lines             4089     4089           
  Branches           711      711           
============================================
  Hits              2882     2882           
  Misses             909      909           
  Partials           298      298
Impacted Files Coverage Δ
src/tabs/tab.directive.ts 88.37% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1f9b7a...3e4823e. Read the comment docs.

@IlyaSurmay IlyaSurmay self-assigned this Oct 4, 2017
…ootstrap into feat-tab-id

Conflicts:
	src/tabs/tab.directive.ts
	src/tabs/tabset.component.ts
@IlyaSurmay IlyaSurmay removed their assignment Oct 4, 2017
@valorkin valorkin added this to the v2.0.0 milestone Oct 13, 2017
@valorkin valorkin merged commit 89defda into development Oct 13, 2017
@valorkin valorkin deleted the feat-tab-id branch October 13, 2017 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding ids to tabs in HTML
2 participants