Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typeahead): add dropup option #2390

Merged
merged 1 commit into from
Aug 21, 2017
Merged

Conversation

IlyaSurmay
Copy link
Contributor

closes #2281

@codecov
Copy link

codecov bot commented Aug 10, 2017

Codecov Report

Merging #2390 into development will increase coverage by 10.92%.
The diff coverage is 50%.

Impacted file tree graph

@@               Coverage Diff                @@
##           development    #2390       +/-   ##
================================================
+ Coverage        75.92%   86.84%   +10.92%     
================================================
  Files              121       96       -25     
  Lines             3614     2730      -884     
  Branches           475      367      -108     
================================================
- Hits              2744     2371      -373     
+ Misses             745      233      -512     
- Partials           125      126        +1
Impacted Files Coverage Δ
src/typeahead/typeahead-container.component.ts 73.61% <ø> (ø) ⬆️
src/typeahead/typeahead.directive.ts 77.77% <50%> (-0.32%) ⬇️
src/collapse/collapse.module.ts 85.71% <0%> (-14.29%) ⬇️
src/buttons/buttons.module.ts 87.5% <0%> (-12.5%) ⬇️
src/datepicker/daypicker.component.ts
src/datepicker/datepicker.module.ts
src/modal/modal-container.component.ts
src/accordion/index.ts
src/rating/index.ts
src/modal/index.ts
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dd456b...04844f5. Read the comment docs.

@YevheniiaMazur
Copy link

Tested, looks good

@valorkin valorkin merged commit c6ef77b into development Aug 21, 2017
@valorkin valorkin deleted the feat-typeahead-dropup branch August 21, 2017 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typeahead option to pop results above input
3 participants