-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed #1629 duplicate tab issue #1941
fixed #1629 duplicate tab issue #1941
Conversation
Codecov Report
@@ Coverage Diff @@
## development #1941 +/- ##
===============================================
+ Coverage 85.93% 86.59% +0.65%
===============================================
Files 78 78
Lines 2098 2104 +6
Branches 273 275 +2
===============================================
+ Hits 1803 1822 +19
+ Misses 202 186 -16
- Partials 93 96 +3
Continue to review full report at Codecov.
|
@JanEggers Can you fix the broken test so this can be merged? |
@valorkin can you please assist? I cant figure out why the test cases i added are not working. Before adding the new test the pr was fine just a little less coverage. |
Sure, I will take a look |
@IlyaSurmay : thx for fixing my pr @valorkin: can u please review and merge |
@SergeyKuryatnick can you tests it so we can merge |
Thanks for PR! |
this is a possible fix for #1629