Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #1629 duplicate tab issue #1941

Merged
merged 7 commits into from
Jun 2, 2017
Merged

fixed #1629 duplicate tab issue #1941

merged 7 commits into from
Jun 2, 2017

Conversation

JanEggers
Copy link
Contributor

@JanEggers JanEggers commented Apr 27, 2017

this is a possible fix for #1629

@codecov
Copy link

codecov bot commented Apr 27, 2017

Codecov Report

Merging #1941 into development will increase coverage by 0.65%.
The diff coverage is 91.66%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1941      +/-   ##
===============================================
+ Coverage        85.93%   86.59%   +0.65%     
===============================================
  Files               78       78              
  Lines             2098     2104       +6     
  Branches           273      275       +2     
===============================================
+ Hits              1803     1822      +19     
+ Misses             202      186      -16     
- Partials            93       96       +3
Impacted Files Coverage Δ
src/tabs/tab.directive.ts 100% <100%> (ø) ⬆️
src/tabs/tabset.component.ts 84.12% <85.71%> (+22.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a828ff3...85475d3. Read the comment docs.

@Flood
Copy link

Flood commented May 2, 2017

@JanEggers Can you fix the broken test so this can be merged?

@JanEggers
Copy link
Contributor Author

@valorkin can you please assist? I cant figure out why the test cases i added are not working.

Before adding the new test the pr was fine just a little less coverage.

@valorkin
Copy link
Member

valorkin commented May 2, 2017

Sure, I will take a look

@JanEggers
Copy link
Contributor Author

@IlyaSurmay : thx for fixing my pr @valorkin: can u please review and merge

@valorkin
Copy link
Member

@SergeyKuryatnick can you tests it so we can merge

@valorkin valorkin assigned valorkin and IlyaSurmay and unassigned valorkin May 25, 2017
@valorkin valorkin merged commit 40335aa into valor-software:development Jun 2, 2017
@valorkin
Copy link
Member

valorkin commented Jun 2, 2017

Thanks for PR!

@JanEggers JanEggers deleted the FixedDuplicateTabsOnUpdate branch June 3, 2017 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants