Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending components, directives etc #1148

Closed
DanielKucal opened this issue Oct 21, 2016 · 1 comment
Closed

Extending components, directives etc #1148

DanielKucal opened this issue Oct 21, 2016 · 1 comment

Comments

@DanielKucal
Copy link
Contributor

DanielKucal commented Oct 21, 2016

Hello everyone, I probably have a feature request. I would like to extend things from this repository in my application. To give an example, I want to implement PopoverDirective basing on ng2-bootstrap TooltipDirective, like here: http://plnkr.co/edit/n5jCg3sK6VRu7fZfj7i2?p=preview
But when i try to do it in my app I get an error:

Error: Template parse errors:
Can't bind to 'popover' since it isn't a known property of 'div'

Above error occurs only when I extend TooltipDirective. I have "popover" set in Directive's selector, constructor() function with proper parameters, copied @inputs() etc., so why it doesn't work?

And second thing: some of the properties are private - why is that? I think that they definitely should be protected to make really extensible components and directives.

Looking forward to hear what you think about it, thanks in advance!

@valorkin
Copy link
Member

Popover added,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants