Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated property 'isOpen' in popover.directive.ts #1765

Merged
merged 1 commit into from
Mar 16, 2017

Conversation

npacucci
Copy link
Contributor

Updated property 'isOpen' into 'show' and 'hide' methods. Through this is possible to use 'toggle' method together with 'show' and 'hide' methods.
Example: if you want to toggle popover by using a button and close it also by click another button inside the popover.

Updated property 'isOpen' into 'show' and 'hide' methods. Through this is possible to use 'toggle' method together with 'show' and 'hide' methods. 
Example: if you want to toggle popover by using a button and close it also by click another button inside the popover.
@codecov-io
Copy link

Codecov Report

Merging #1765 into development will increase coverage by 0.05%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           development    #1765      +/-   ##
===============================================
+ Coverage        85.41%   85.47%   +0.05%     
===============================================
  Files               85       85              
  Lines             2290     2292       +2     
  Branches           300      300              
===============================================
+ Hits              1956     1959       +3     
+ Misses             235      234       -1     
  Partials            99       99
Impacted Files Coverage Δ
src/popover/popover.directive.ts 100% <100%> (+2.7%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a7719b...b69505e. Read the comment docs.

@npacucci
Copy link
Contributor Author

@valorkin it's possible to merge this? Thanks! 😄

@valorkin valorkin merged commit 363d9e6 into valor-software:development Mar 16, 2017
@valorkin
Copy link
Member

thanks for help! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants