You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The JSON files describing the commands include ACL categories, but these are not the final ACL categories used. Valkey adds some implicit ones depending on "command flags" which are also from the same JSON files.
To remove this discrepancy and make the JSON files more usable as-is, we'd need:
Add all implicit ACL categories in the JSON files,
Validate that the JSON files follow the rules for implicit ACL categories. This can be done in utils/generate-command-code.py.
Remove the code that adds implicit ACL categories, the function setImplicitACLCategories() in server.c.
The JSON files describing the commands include ACL categories, but these are not the final ACL categories used. Valkey adds some implicit ones depending on "command flags" which are also from the same JSON files.
To remove this discrepancy and make the JSON files more usable as-is, we'd need:
utils/generate-command-code.py
.setImplicitACLCategories()
inserver.c
.This is a follow-up of #403.
The text was updated successfully, but these errors were encountered: