Embed keys and hash fields as SDS type 5 #1613
Draft
+114
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now, these embedded strings were SDS type 8, becuase they were copied as-is from EMBSTR encoded string objects, which always use SDS type 8. This change allows them to be embedded as SDS type 5, saving two bytes. The implementation of embeddeding SDS strings in other structures is refactored. sdswrite() is a new function to create an SDS representation into a buffer provided by the caller, instead of allocating it. sdscopytobuffer() which just copied the layout of an existing sds is deleted. The DEBUG SDSLEN command output is changed slightly, to account for correct allocation sizes for embedded strings and not report the same memory twice. Signed-off-by: Viktor Söderqvist <[email protected]>
zuiderkwast
changed the title
Signed-off-by: Viktor Söderqvist <[email protected]>
Signed-off-by: Viktor Söderqvist <[email protected]>
Signed-off-by: Viktor Söderqvist <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, these embedded strings were SDS type 8, because they were copied as-is from EMBSTR encoded string objects, which always use SDS type 8. This change allows them to be embedded as SDS type 5, saving two bytes.
The implementation of embeddeding SDS strings in other structures is refactored.
sdswrite()is a new function to create an SDS representation into a buffer provided by the caller, instead of allocating it.sdscopytobuffer()which just copied the layout of an existing sds is deleted.The DEBUG SDSLEN command output is changed slightly, to account for correct allocation sizes of embedded strings and not report the same memory twice.
Fixes #1567