Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test Failure] Sometimes failing valgrind test #1484

Open
madolson opened this issue Dec 24, 2024 · 2 comments · May be fixed by #1612
Open

[Test Failure] Sometimes failing valgrind test #1484

madolson opened this issue Dec 24, 2024 · 2 comments · May be fixed by #1612
Labels
test-failure An issue indicating a test failure

Comments

@madolson
Copy link
Member

We sometimes get a valgrind failure with no error, just printing out valgrind text:

Example: https://github.com/valkey-io/valkey/actions/runs/12474649298/job/34816982513

!!! WARNING The following tests failed:

*** [err]: Valgrind error: ==90396== Memcheck, a memory error detector
==90396== Copyright (C) 2002-2022, and GNU GPL'd, by Julian Seward et al.
==90396== Using Valgrind-3.22.0 and LibVEX; rerun with -h for copyright info
==90396== Command: src/valkey-server ./tests/tmp/valkey.conf.3985.1683
==90396== 

There might be more of an error that is getting truncated. Not sure what is causing it.

@madolson madolson added the test-failure An issue indicating a test failure label Dec 24, 2024
@madolson
Copy link
Member Author

Looking into this quickly, I'm guessing the report isn't fully written out yet, because it's missing some elements like "definitely lost" and such.

@madolson
Copy link
Member Author

Looking more deeply, these seem to be that this is because the process is failing to exit. We can see that the we force the process to crash, and it's not exiting.

See https://github.com/valkey-io/valkey/actions/runs/12474649298/job/34816982513#step:6:5057.

Tue, 24 Dec 2024 01:55:09 GMT
[ok]: Test dual-channel-replication primary gets cob overrun during replica rdb load (15579 ms)
Tue, 24 Dec 2024 01:55:10 GMT
Waiting for process 90396 to exit...

... blah blah ...

Tue, 24 Dec 2024 01:59:33 GMT
Forcing process 90396 to exit...
Tue, 24 Dec 2024 01:59:33 GMT
[err]: Valgrind error: ==90396== Memcheck, a memory error detector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-failure An issue indicating a test failure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant