Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: Deprecated cargo-deny Configuration Keys in deny.toml #2236

Closed
MikeMwita opened this issue Sep 5, 2024 · 3 comments · Fixed by #2235
Closed

Go: Deprecated cargo-deny Configuration Keys in deny.toml #2236

MikeMwita opened this issue Sep 5, 2024 · 3 comments · Fixed by #2235
Labels
bug Something isn't working

Comments

@MikeMwita
Copy link
Collaborator

Describe the bug

When running the cargo deny check command, the following deprecated keys in the deny.toml configuration cause the check to fail:

vulnerability = "deny"
unmaintained = "deny"
unsound = "deny"
notice = "deny"
unlicensed = "deny"
default = "deny"
These keys have been removed as per this update. The command throws multiple errors indicating the removal of these keys, preventing the tool from executing successfully.

Expected Behavior

The cargo deny check command should execute without errors after updating to the latest configuration syntax.

Current Behavior

This is the current output when running cargo deny check command locally
image

Reproduction Steps

Clone the repository.
Run cargo deny check.
Observe the errors regarding deprecated keys in the deny.toml file.

Possible Solution

It appears that the configuration file needs to be updated to remove deprecated keys and adopt the new schema, as outlined in the cargo-deny update.

Additional Information/Context

No response

Client version used

cargo 1.80.1

Engine type and version

rustc 1.80.1

OS

Linux

Language

Go

Language Version

1.22.0

Cluster information

No response

Logs

No response

Other information

No response

@MikeMwita MikeMwita added the bug Something isn't working label Sep 5, 2024
@MikeMwita MikeMwita changed the title Go:( Deprecated cargo-deny Configuration Keys in deny.toml Go: Deprecated cargo-deny Configuration Keys in deny.toml Sep 5, 2024
@Yury-Fridlyand
Copy link
Collaborator

Will be fixed in #2235

@Yury-Fridlyand Yury-Fridlyand linked a pull request Sep 5, 2024 that will close this issue
@avifenesh
Copy link
Collaborator

Will be fixed in #2235

@Yury-Fridlyand please insist on real fixes and not bypasses, it's not a fix.

@Yury-Fridlyand
Copy link
Collaborator

#2235 (comment)

@avifenesh Are you ok to postpone all merges and releases until all required dependencies are updated? ETA somewhere in between -∞ to +∞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants