Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2448 : isUrl fails for URLs that do not use domain suffixes #2476

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vivekmahindrakar
Copy link

feat(isURL): fix for isUrl fails for URLs that do not use domain suffixes

if (options.require_valid_protocol && options.protocols.indexOf(protocol) === -1) changed to if (options.require_valid_protocol && !protocol)

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant