Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2370 readme.md toBoolean function documentation typo - solved , Update README.md #2373

Closed
wants to merge 1 commit into from

Conversation

Anayverma
Copy link

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

Copy link

codecov bot commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b958bd7) 99.95% compared to head (c68262f) 99.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2373      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files         107      107              
  Lines        2454     2449       -5     
  Branches      619      619              
==========================================
- Hits         2453     2448       -5     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WikiRik
Copy link
Member

WikiRik commented Mar 6, 2024

As mentioned in #2374; let's come to a conclusion on the wanted text in #2370 first.

The first sentence of your suggestion is not consistent with the first sentences of the other validators

@Anayverma
Copy link
Author

could you provide me any suggestions ?

@WikiRik
Copy link
Member

WikiRik commented May 7, 2024

As #2370 has been closed because the consensus is that we already use the correct text, I'm closing this PR as well

@WikiRik WikiRik closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants