Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(isMobilePhone): update phone regex for Ukraine uk-UA #2359

Merged
merged 4 commits into from
Jun 1, 2024

Conversation

arttiger
Copy link
Contributor

@arttiger arttiger commented Jan 13, 2024

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

See more: International Telecommunication Union (ITU)

Copy link

codecov bot commented Jan 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (b958bd7) to head (4378c01).
Report is 24 commits behind head on master.

Current head 4378c01 differs from pull request most recent head 521e7c3

Please upload reports for the commit 521e7c3 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2359      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files         107      107              
  Lines        2454     2449       -5     
  Branches      619      619              
==========================================
- Hits         2453     2448       -5     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/lib/isMobilePhone.js Outdated Show resolved Hide resolved
Minor suggestion to reduce the length of the expression аnd add two new mobile operators
@arttiger arttiger requested a review from WikiRik May 8, 2024 08:18
@profnandaa profnandaa merged commit c25b98f into validatorjs:master Jun 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants