Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isISO4217): update iso4217 currency codes according to wiki #2332

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

cbodtorf
Copy link
Contributor

feat(isISO4217): update iso4217 currency codes according to wiki

  • Removed 'CUC' and 'HRK' currency codes
Code Num D Currency From Until Replaced by
HRK 191 2 Croatian kuna 1994-05-30 2023-01-01 EUR[31]
CUC 931 2 Cuban convertible peso 2022 CUP
  • Added 'SLE' and 'VED' currency codes
Code Num D Currency Locations
SLE 925 2 Sierra Leonean leone (new leone)[12][13][14] image Sierra Leone
VED 926 2 Venezuelan digital bolívar[18] image Venezuela

Resources:

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b958bd7) 99.95% compared to head (5c382bc) 99.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2332      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files         107      107              
  Lines        2454     2449       -5     
  Branches      619      619              
==========================================
- Hits         2453     2448       -5     
  Partials        1        1              
Files Coverage Δ
src/lib/isISO4217.js 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

WikiRik
WikiRik previously approved these changes Oct 29, 2023
rubiin
rubiin previously approved these changes May 12, 2024
@rubiin rubiin dismissed stale reviews from WikiRik and themself via 030033d June 3, 2024 14:34
@rubiin rubiin requested review from WikiRik and profnandaa June 3, 2024 14:34
@profnandaa profnandaa merged commit f2bc5ed into validatorjs:master Jun 4, 2024
10 checks passed
@profnandaa
Copy link
Member

Thanks for your contrib!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants