Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: escape and unescape #2325

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Conversation

ovarn
Copy link
Contributor

@ovarn ovarn commented Oct 14, 2023

The doc for the escape and unescape doesn't match the implementation:

.replace(/\\/g, '\')
.replace(/`/g, '`'));

.replace(/\/g, '\\')
.replace(/`/g, '`')

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@ovarn ovarn changed the title Fix escape and unescape docs docs: escape and unescape Oct 14, 2023
@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b958bd7) 99.95% compared to head (3ab8fde) 99.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2325      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files         107      107              
  Lines        2454     2449       -5     
  Branches      619      619              
==========================================
- Hits         2453     2448       -5     
  Partials        1        1              

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ovarn ovarn requested a review from WikiRik October 16, 2023 08:46
@ovarn
Copy link
Contributor Author

ovarn commented Oct 16, 2023

Sorry @WikiRik, I unintentionally clicked the "Re-request review".

@rubiin rubiin merged commit d3db30d into validatorjs:master Jun 4, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants