-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix typos #2323
docs: fix typos #2323
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2323 +/- ##
===========================================
- Coverage 100.00% 99.95% -0.05%
===========================================
Files 109 107 -2
Lines 2489 2449 -40
Branches 628 619 -9
===========================================
- Hits 2489 2448 -41
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. |
@ovarn please fix the merge conflicts so we may merge this :) |
I'll try to find the time today or tomorrow. Thanks! |
@ovarn no worries . I fixed them :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second thought, 'uk-UA' this seems to be deleted. Please check if that was a change you made
Looks like it was removed during the merge. When I did this PR, there was no 'uk-UA' in the |
@rubiin what would be the best approach to fix it? Should I revert the merge and do it again? Or should I just add the lang as an another commit? |
since the changes are minor, the best approach is to stash your edits, pull the latest changes and add in your change. That we you wont get a merge conflict as you are working on latest changes |
Thanks! It's done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
The
README.md
file contained a few typos.Checklist