-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added mobile phone validations for the 10 countries. #2302
base: master
Are you sure you want to change the base?
Added mobile phone validations for the 10 countries. #2302
Conversation
…Swaziland, Basque, Laos, Macedonia, Saint Vincent and the Grenadines, Grenada, Botswana, Palau, Tonga.
…Swaziland, Basque, Laos, Macedonia, Saint Vincent and the Grenadines, Grenada, Palau, Tonga.
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2302 +/- ##
==========================================
- Coverage 99.95% 99.95% -0.01%
==========================================
Files 107 107
Lines 2454 2449 -5
Branches 619 619
==========================================
- Hits 2453 2448 -5
Partials 1 1
☔ View full report in Codecov by Sentry. |
Please add the relevant test cases. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests in the validators.test.js file and provide sources for these validators in the PR description
I added test cases. please review my PR |
any update on this PR ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add references as well
feat(phone-validations): added validations for Croatia, Swaziland, Basque, Laos, Macedonia, Saint Vincent and the Grenadines, Grenada, Botswana, Palau, Tonga
Added phone number validations for multiple countries
This PR includes validations for phone numbers in Croatia, Swaziland, Basque, Laos, Macedonia, Saint Vincent and the Grenadines, Grenada, Botswana, Palau, and Tonga.
Enhanced #1761
Checklist