Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mobile phone validations for the 10 countries. #2302

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

amansaurabh
Copy link

@amansaurabh amansaurabh commented Oct 2, 2023

feat(phone-validations): added validations for Croatia, Swaziland, Basque, Laos, Macedonia, Saint Vincent and the Grenadines, Grenada, Botswana, Palau, Tonga

Added phone number validations for multiple countries

This PR includes validations for phone numbers in Croatia, Swaziland, Basque, Laos, Macedonia, Saint Vincent and the Grenadines, Grenada, Botswana, Palau, and Tonga.

Enhanced #1761

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

…Swaziland, Basque, Laos, Macedonia, Saint Vincent and the Grenadines, Grenada, Botswana, Palau, Tonga.
…Swaziland, Basque, Laos, Macedonia, Saint Vincent and the Grenadines, Grenada, Palau, Tonga.
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b958bd7) 99.95% compared to head (6a12aef) 99.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2302      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files         107      107              
  Lines        2454     2449       -5     
  Branches      619      619              
==========================================
- Hits         2453     2448       -5     
  Partials        1        1              
Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Daniyal-Qureshi
Copy link
Contributor

Please add the relevant test cases.

@amansaurabh
Copy link
Author

Please add the relevant test cases.
I'm new to writing tests and could use some guidance on where and how to add them.
Could you please help me in the right direction or provide some examples of what a good test case looks like in this context?

Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests in the validators.test.js file and provide sources for these validators in the PR description

@amansaurabh
Copy link
Author

I added test cases. please review my PR

@Sufiane
Copy link

Sufiane commented Oct 31, 2024

any update on this PR ?

Copy link
Member

@rubiin rubiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add references as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants