Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ulid): ULID validation #2294

Merged
merged 3 commits into from
Jun 23, 2024
Merged

Conversation

arafatkn
Copy link
Contributor

Added validation for ULID (Universally Unique Lexicographically Sortable Identifier).

Read more details on ULID in github:ulid/spec
ULID Generator and validations on https://ulid.page

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (f81d857) to head (9891a3b).
Report is 1 commits behind head on master.

Current head 9891a3b differs from pull request most recent head 0995b5c

Please upload reports for the commit 0995b5c to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##            master    #2294      +/-   ##
===========================================
- Coverage   100.00%   99.95%   -0.05%     
===========================================
  Files          110      108       -2     
  Lines         2510     2455      -55     
  Branches       633      620      -13     
===========================================
- Hits          2510     2454      -56     
- Partials         0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rubiin
rubiin previously approved these changes May 10, 2024
@rubiin rubiin requested review from profnandaa and ezkemboi June 4, 2024 08:29
@profnandaa profnandaa added the mc-to-land Just merge-conflict standing between the PR and landing. label Jun 22, 2024
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pls fix the merge conflict and we should be good to go.

@arafatkn
Copy link
Contributor Author

@profnandaa
I have fixed the conflicts.

rubiin
rubiin previously approved these changes Jun 22, 2024
@rubiin rubiin requested a review from profnandaa June 22, 2024 17:57
@rubiin rubiin removed the mc-to-land Just merge-conflict standing between the PR and landing. label Jun 23, 2024
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@profnandaa profnandaa merged commit 1f159ea into validatorjs:master Jun 23, 2024
10 checks passed
@arafatkn arafatkn deleted the feat/ulid branch July 2, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants