Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation Issue: Incorrect ES Import Path #2528

Open
saar-twito opened this issue Feb 9, 2025 · 1 comment · May be fixed by #2531
Open

Documentation Issue: Incorrect ES Import Path #2528

saar-twito opened this issue Feb 9, 2025 · 1 comment · May be fixed by #2531
Labels
🐛 bug

Comments

@saar-twito
Copy link

The documentation on npm indicates that tree-shakeable ES imports should be done using: import isEmail from 'validator/es/lib/isEmail.js'. However, the es folder does not exist in the package. Only the path validator/lib/isEmail.js works.

Either the es folder should exist to support ES imports as documented, or the documentation should be updated to reflect the correct import path (validator/lib/isEmail.js).
@akshatsh0610 akshatsh0610 linked a pull request Feb 10, 2025 that will close this issue
Open
4 tasks
@WikiRik
Copy link
Member

WikiRik commented Feb 10, 2025

If I'm looking through the published files in NPM, I do see that file. It's not in the repo since it's generated upon preparing a release.
What is the error you are getting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update README.md akshatsh0610/validator.js
2 participants
@WikiRik @saar-twito