Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Criticals from libvala #274

Open
lw64 opened this issue Nov 16, 2022 · 3 comments
Open

Criticals from libvala #274

lw64 opened this issue Nov 16, 2022 · 3 comments
Labels
bug upstream Requires changes in upstream components (libvala, GLib, etc)

Comments

@lw64
Copy link
Contributor

lw64 commented Nov 16, 2022

While using vls very often criticals appear on stderr. This should be avoided.

@sonnyp
Copy link

sonnyp commented Nov 16, 2022

For some context:

@lw64 added support for vala-language-server in Workbench 🥳 workbenchdev/Workbench#156

Workbench has a terminal in readonly mode for debugging. We used to show language servers stderr in there to help with user reports.

We had to stop because vls emit tons of criticals.

image

@Prince781
Copy link
Member

These are criticals in libvala (notice the vala-CRITICAL), not VLS, which uses the vls namespace. So an upstream issue

@ricotz can chime in. I had a PR that would address some of this problem. IIRC most of these are from Vala.GirParser which gets called when we're building documentation for the first time.

@Prince781 Prince781 added the enhancement A new feature label Nov 17, 2022
@sonnyp
Copy link

sonnyp commented Dec 11, 2022

FYI - Blueprint language server is also very verbose on stderr so I decided to stop displaying it to users.

@Prince781 Prince781 added the upstream Requires changes in upstream components (libvala, GLib, etc) label Apr 1, 2023
@Prince781 Prince781 changed the title Criticals Criticals from libvala Apr 1, 2023
@Prince781 Prince781 added bug and removed enhancement A new feature labels Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug upstream Requires changes in upstream components (libvala, GLib, etc)
Projects
None yet
Development

No branches or pull requests

3 participants