Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metapackage type affects cwd for patching (documentation suggestion) #90

Open
johnorourke opened this issue Feb 7, 2022 · 2 comments
Open

Comments

@johnorourke
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I have a composer module containing just a composer.json, and a xxxxx.patch file. I accidentally had "type":"metapackage" in my module's composer.json. When including this module in the project, I got a "file not found" error. Changing the package type made it find the patch file.

Describe the solution you'd like
We should mention this in the documentation, but where? I guess ERRORS.md would be best.

Additional context
I'm happy to do the work, just wanted guidance on where to add the doc.

@johnorourke johnorourke changed the title metapackage type affects cwd for patching metapackage type affects cwd for patching (documentation suggestion) Feb 7, 2022
@vaimo-wilko
Copy link
Member

Thank you for this report.

ERRORS.md could be one place, but perhaps (also) in this section, the 2nd bullet (dependency packages) could make a reference to what type it should be to work?

@johnorourke
Copy link
Contributor Author

@vaimo-wilko thanks, I'll put in a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants